Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Upload both coverage reports (mbt + integration) at once #713

Closed
romac opened this issue Dec 19, 2024 · 1 comment
Closed

ci: Upload both coverage reports (mbt + integration) at once #713

romac opened this issue Dec 19, 2024 · 1 comment
Labels
ci Related to CI good first issue Good for newcomers
Milestone
Phase 5

Comments

@romac
Copy link
Member

romac commented Dec 19, 2024 •
edited
Loading

We currently upload both reports as soon as they are ready, with mbt typically being the first to be reported, which annoyingly marks PRs as failed and shows a wrong coverage % in the codecov app and badge, until the second report is uploaded.

Instead we should modify the coverage workflow so that it first generates both reports and then upload them simultaneously to Codecov instead of doing it separately straight away.
@romac romac added the ci Related to CI label Dec 19, 2024
@romac romac added this to the Phase 5 milestone Dec 19, 2024
@romac romac added the good first issue Good for newcomers label Dec 19, 2024
@nuts-rice nuts-rice mentioned this issue Jan 13, 2025
Merged
@romac
Copy link
Member Author

romac commented Jan 15, 2025

Fixed in #759

@romac romac closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Related to CI good first issue Good for newcomers
Projects
None yet
Milestone
Phase 5
Development

No branches or pull requests
1 participant
@romac