Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounds Checking For Dates #69

Open
WillAyd opened this issue Jan 2, 2020 · 1 comment
Open

Bounds Checking For Dates #69

WillAyd opened this issue Jan 2, 2020 · 1 comment
Labels

Comments

@WillAyd
Copy link
Collaborator

WillAyd commented Jan 2, 2020

The Hyper API establishes a date as a uint32, a time as a uint64 but I think writes both in as a int64

There are probably some weird edge cases when values cross the limits of int64 into uint64 so might want to do explicit bounds checking rather than the casts currently in code

@WillAyd WillAyd added the help wanted Extra attention is needed label Jan 2, 2020
@WillAyd
Copy link
Collaborator Author

WillAyd commented Feb 2, 2024

The details of the OP aren't relevant in pantab 4.x, but the problem still remains

@WillAyd WillAyd added hacktoberfest and removed help wanted Extra attention is needed labels Oct 10, 2024
@WillAyd WillAyd added the c++ label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant