Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom element to readme #325

Open
lekoala opened this issue Jan 8, 2024 · 5 comments
Open

Add custom element to readme #325

lekoala opened this issue Jan 8, 2024 · 5 comments

Comments

@lekoala
Copy link

lekoala commented Jan 8, 2024

Hi there,

Great library!

If you are interested to add it to the readme, I created a custom element that wraps your library

https://github.com/lekoala/formidable-elements/blob/master/demo/count-up.html

Some points you might find interesting:

  • automated usage of intersection observer (i think this replace nicely the scrollspy feature that is more complex that needed)
  • option to use Intl.NumberFormat is wanted (something hard to achieve in pure js)
  • auto detect decimals (for simple cases)
@inorganik
Copy link
Owner

Those are some nice enhancements, and Formidable elements looks like a nice library! Looks like they are web components and framework agnostic?

I'm happy to include this in the README, but I would like to give the user a little more context around usage, if they are like me and have never used custom elements/web components. I'd appreciate any extra context you can give. Thanks!

@lekoala
Copy link
Author

lekoala commented Jan 15, 2024

yes the idea is to have standalone, autonomous components. currently since it's easier to maintain i have everything under one repo. it has no stable release yet because i'm still deciding if each component needs to have its own repo but that seems like a lot of maintenance :)

fully agree with you it may need a bit more context, i'll let you know once its done

@lekoala
Copy link
Author

lekoala commented Jan 15, 2024

@inorganik
Copy link
Owner

Thanks for that quick turnaround. I was thinking of adding a link to that readme under the "use countUp with" bulleted list. What should I call it - does this look ok?

@lekoala
Copy link
Author

lekoala commented Jan 17, 2024

looking great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants