New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.7 Support #4

Open

Athanasius opened this issue Jun 30, 2020 · 1 comment

Athanasius commented Jun 30, 2020

Despite having a plugin_start3() which initially made me think this was updated for Python 3.7 it seems this plugin isn't fully ready after all.

https://github.com/inorton/EDMCJumpSpeed/blob/master/load.py#L203

is missing the 'is_beta' argument. There might be other such as well.

Confirm it's fixed up and tested as working and I'll move it back into the 'supported' section on https://github.com/EDCD/EDMarketConnector/wiki/Plugins

Contributor

RapidfireCRH commented Jul 3, 2020

Created a pr fixing the plugin. Working on 3.99.1.0 with added is_beta tag in journal_entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment