From a0251122e28a93385f31afd652aa0c7cd6088a31 Mon Sep 17 00:00:00 2001 From: Resaki1 Date: Tue, 14 Jan 2025 11:45:05 +0100 Subject: [PATCH 01/11] darkened all yellow tones, removed shadow from vote button, removed background from delete button, and added tooltip to vote buttons --- src/components/DotButton/DotButton.tsx | 4 ++++ .../NoteDialogDeleteNoteButton.scss | 3 ++- .../NoteDialogOptions/NoteDialogNoteOptions.scss | 9 +++++++++ .../NoteDialogOptions/NoteDialogNoteOptions.tsx | 2 +- .../NoteDialogNoteWrapper.scss | 2 +- .../Votes/VoteButtons/AddVoteButton.scss | 4 ---- .../Votes/VoteButtons/AddVoteButton.tsx | 9 ++++++++- .../Votes/VoteButtons/RemoveVoteButton.scss | 4 ---- .../Votes/VoteButtons/RemoveVoteButton.tsx | 2 ++ src/constants/colors.scss | 16 ++++++++-------- 10 files changed, 35 insertions(+), 20 deletions(-) diff --git a/src/components/DotButton/DotButton.tsx b/src/components/DotButton/DotButton.tsx index 4fea2cb356..46a2b3cc35 100644 --- a/src/components/DotButton/DotButton.tsx +++ b/src/components/DotButton/DotButton.tsx @@ -8,6 +8,8 @@ type DotButtonProps = { onClick?: () => void; title?: string; onAnimationEnd?: () => void; + dataTooltipId?: string; + dataTooltipContent?: string; }; export const DotButton: FC> = (props) => ( @@ -20,6 +22,8 @@ export const DotButton: FC> = (props) => ( }} title={props.title} onAnimationEnd={props.onAnimationEnd} + data-tooltip-id={props.dataTooltipId} + data-tooltip-content={props.dataTooltipContent} > {props.children} diff --git a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogDeleteNoteButton.scss b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogDeleteNoteButton.scss index f122e257b2..7fcfe1e392 100644 --- a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogDeleteNoteButton.scss +++ b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogDeleteNoteButton.scss @@ -7,7 +7,8 @@ display: flex; justify-content: center; align-items: center; - background-color: rgba(var(--accent-color--light-rgb), 0.2); + // no background + background-color: transparent !important; color: var(--accent-color--light); transition: background-color 150ms ease-in-out, diff --git a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.scss b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.scss index ff44295db5..55fca6db24 100644 --- a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.scss +++ b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.scss @@ -42,6 +42,11 @@ &:focus-visible { outline: 2px solid var(--accent-color--light); } + + &--secondary { + background-color: transparent; + box-shadow: none; + } } [theme="dark"] { @@ -56,5 +61,9 @@ &:focus-visible { outline: 2px solid rgba(var(--accent-color--dark-rgb), 0.6); } + + &--secondary { + background-color: transparent; + } } } diff --git a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.tsx b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.tsx index f6f96673fd..6a7d415d93 100644 --- a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.tsx +++ b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.tsx @@ -79,7 +79,7 @@ export const NoteDialogNoteOptions: FC = (props: Not props.isStackedNote || !props.hasStackedNotes || !allowedToDeleteStack ? t("NoteDialogDeleteNoteButton.title") : t("NoteDialogDeleteStackButton.title") } aria-label={props.isStackedNote || !props.hasStackedNotes || !allowedToDeleteStack ? t("NoteDialogDeleteNoteButton.title") : t("NoteDialogDeleteStackButton.title")} - className="note-option__button" + className="note-option__button note-option__button--secondary" onClick={() => { onDelete(props.noteId); }} diff --git a/src/components/NoteDialogComponents/NoteDialogNoteWrapper.scss b/src/components/NoteDialogComponents/NoteDialogNoteWrapper.scss index f8298e002e..08756d185b 100644 --- a/src/components/NoteDialogComponents/NoteDialogNoteWrapper.scss +++ b/src/components/NoteDialogComponents/NoteDialogNoteWrapper.scss @@ -22,7 +22,7 @@ display: flex; flex-direction: column; align-items: center; - + padding-bottom: $spacing--base; gap: $spacing--base; } diff --git a/src/components/Votes/VoteButtons/AddVoteButton.scss b/src/components/Votes/VoteButtons/AddVoteButton.scss index eca823af30..4bc45a0d02 100644 --- a/src/components/Votes/VoteButtons/AddVoteButton.scss +++ b/src/components/Votes/VoteButtons/AddVoteButton.scss @@ -14,9 +14,6 @@ transition: background-color 80ms ease-in-out, color 80ms ease-in-out; - box-shadow: - 0 1px 3px 0 rgba(var(--accent-color--light-rgb), 0.1), - 0 1px 2px -1px rgba(var(--accent-color--light-rgb), 0.1); } .vote-button-add:disabled { opacity: 0.5; @@ -40,7 +37,6 @@ .vote-button-add { background-color: rgba(var(--accent-color--dark-rgb), 0.6); color: var(--accent-color--dark); - filter: drop-shadow(0 3px 4px rgba($navy--900, 0.16)); &:enabled:hover { background-color: var(--accent-color--dark); diff --git a/src/components/Votes/VoteButtons/AddVoteButton.tsx b/src/components/Votes/VoteButtons/AddVoteButton.tsx index 0af493f79b..b32578f5d8 100644 --- a/src/components/Votes/VoteButtons/AddVoteButton.tsx +++ b/src/components/Votes/VoteButtons/AddVoteButton.tsx @@ -20,7 +20,14 @@ export const AddVoteButton: FC = ({noteId, disabled}) => { }; return ( - + ); diff --git a/src/components/Votes/VoteButtons/RemoveVoteButton.scss b/src/components/Votes/VoteButtons/RemoveVoteButton.scss index 25ebe93b7f..66391a3bd5 100644 --- a/src/components/Votes/VoteButtons/RemoveVoteButton.scss +++ b/src/components/Votes/VoteButtons/RemoveVoteButton.scss @@ -14,9 +14,6 @@ transition: background-color 80ms ease-in-out, color 80ms ease-in-out; - box-shadow: - 0 1px 3px 0 rgba(var(--accent-color--light-rgb), 0.1), - 0 1px 2px -1px rgba(var(--accent-color--light-rgb), 0.1); } .vote-button-remove:disabled { @@ -93,7 +90,6 @@ .vote-button-remove { color: $gray--000; background-color: rgba(var(--accent-color--dark-rgb), 0.6); - filter: drop-shadow(0 3px 4px rgba($navy--900, 0.16)); &:enabled:hover { background-color: var(--accent-color--dark); diff --git a/src/components/Votes/VoteButtons/RemoveVoteButton.tsx b/src/components/Votes/VoteButtons/RemoveVoteButton.tsx index 71d91613f5..eae3bfc737 100644 --- a/src/components/Votes/VoteButtons/RemoveVoteButton.tsx +++ b/src/components/Votes/VoteButtons/RemoveVoteButton.tsx @@ -41,6 +41,8 @@ export const RemoveVoteButton: FC = ({noteId, disabled, numberO onAnimationEnd={() => { setDoBump(false); }} + dataTooltipId="scrumlr-tooltip" + dataTooltipContent={t("Votes.RemoveVote")} > diff --git a/src/constants/colors.scss b/src/constants/colors.scss index bc97345d66..211b5cfcea 100644 --- a/src/constants/colors.scss +++ b/src/constants/colors.scss @@ -53,14 +53,14 @@ $green--200: #a4eecb; $green--100: #d1f6e5; // yellow -$yellow--800: #666200; -$yellow--700: #999300; -$yellow--600: #ccc400; -$yellow--500: #fff500; // primary light -$yellow--400: #fff733; // primary dark -$yellow--300: #fff966; -$yellow--200: #fffb99; -$yellow--100: #fffdcc; +$yellow--800: #9f7b00; +$yellow--700: #bf9400; +$yellow--600: #dfad00; +$yellow--500: #fbd40c; // primary light +$yellow--400: #fcde48; // primary dark +$yellow--300: #fde985; +$yellow--200: #fef4c2; +$yellow--100: #fef9e0; // orange $orange--800: #664300; From 5cb8ed921ece8a4e591dbbf030ddf26c701609c0 Mon Sep 17 00:00:00 2001 From: Resaki1 Date: Wed, 15 Jan 2025 10:26:43 +0100 Subject: [PATCH 02/11] removed title from vote buttons and improved translation pluralization --- .../NoteDialogOptions/NoteDialogNoteOptions.scss | 1 - src/components/Votes/VoteButtons/AddVoteButton.tsx | 9 +-------- src/components/Votes/VoteButtons/RemoveVoteButton.tsx | 3 +-- src/i18n/de/translation.json | 3 ++- src/i18n/en/translation.json | 3 ++- 5 files changed, 6 insertions(+), 13 deletions(-) diff --git a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.scss b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.scss index 55fca6db24..4b2053eb77 100644 --- a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.scss +++ b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.scss @@ -55,7 +55,6 @@ color: var(--accent-color--dark); &:hover { - background-color: var(--accent-color--light); color: $gray--000; } &:focus-visible { diff --git a/src/components/Votes/VoteButtons/AddVoteButton.tsx b/src/components/Votes/VoteButtons/AddVoteButton.tsx index b32578f5d8..6c12eade95 100644 --- a/src/components/Votes/VoteButtons/AddVoteButton.tsx +++ b/src/components/Votes/VoteButtons/AddVoteButton.tsx @@ -20,14 +20,7 @@ export const AddVoteButton: FC = ({noteId, disabled}) => { }; return ( - + ); diff --git a/src/components/Votes/VoteButtons/RemoveVoteButton.tsx b/src/components/Votes/VoteButtons/RemoveVoteButton.tsx index eae3bfc737..7246bccf64 100644 --- a/src/components/Votes/VoteButtons/RemoveVoteButton.tsx +++ b/src/components/Votes/VoteButtons/RemoveVoteButton.tsx @@ -34,7 +34,6 @@ export const RemoveVoteButton: FC = ({noteId, disabled, numberO return ( = ({noteId, disabled, numberO setDoBump(false); }} dataTooltipId="scrumlr-tooltip" - dataTooltipContent={t("Votes.RemoveVote")} + dataTooltipContent={disabled ? t("Votes.VotesOnNote", {count: numberOfVotes}) : t("Votes.RemoveVote")} > diff --git a/src/i18n/de/translation.json b/src/i18n/de/translation.json index 4d27b1bad0..ae9c812c34 100644 --- a/src/i18n/de/translation.json +++ b/src/i18n/de/translation.json @@ -672,7 +672,8 @@ "Votes": { "AddVote": "Stimme hinzufügen", "RemoveVote": "Stimme entfernen", - "VotesOnNote": "{{votes}} Stimme(n)" + "VotesOnNote_one": "{{count}} Stimme", + "VotesOnNote_other": "{{count}} Stimmen" }, "Snowfall": { "toastTitle": "Frohe Feiertage 🎄", diff --git a/src/i18n/en/translation.json b/src/i18n/en/translation.json index 8222289bcc..5bb94845ba 100644 --- a/src/i18n/en/translation.json +++ b/src/i18n/en/translation.json @@ -672,7 +672,8 @@ "Votes": { "AddVote": "Add vote", "RemoveVote": "Remove vote", - "VotesOnNote": "{{votes}} vote(s)" + "VotesOnNote_one": "{{count}} vote", + "VotesOnNote_other": "{{count}} votes" }, "Snowfall": { "toastTitle": "Happy Holidays 🎄", From a416c4fdeed49fb523053ced99e336a06dc5a462 Mon Sep 17 00:00:00 2001 From: Resaki1 Date: Wed, 15 Jan 2025 10:57:31 +0100 Subject: [PATCH 03/11] improved disabled state of vote buttons --- .../Votes/VoteButtons/AddVoteButton.scss | 29 ++++++++++++------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/src/components/Votes/VoteButtons/AddVoteButton.scss b/src/components/Votes/VoteButtons/AddVoteButton.scss index 4bc45a0d02..8a860ed44b 100644 --- a/src/components/Votes/VoteButtons/AddVoteButton.scss +++ b/src/components/Votes/VoteButtons/AddVoteButton.scss @@ -14,9 +14,20 @@ transition: background-color 80ms ease-in-out, color 80ms ease-in-out; -} -.vote-button-add:disabled { - opacity: 0.5; + + &:enabled:hover { + background-color: var(--accent-color--light); + color: $gray--000; + } + + &:focus-visible { + outline: 2px solid rgba(var(--accent-color--light-rgb), 0.5); + } + + &:disabled { + background-color: $gray--200; + color: $gray--600; + } } .vote-button-add__icon { @@ -25,13 +36,6 @@ color: inherit; pointer-events: none; } -.vote-button-add:enabled:hover { - background-color: var(--accent-color--light); - color: $gray--000; -} -.vote-button-add:focus-visible { - outline: 2px solid rgba(var(--accent-color--light-rgb), 0.5); -} [theme="dark"] { .vote-button-add { @@ -41,5 +45,10 @@ &:enabled:hover { background-color: var(--accent-color--dark); } + + &:disabled { + background-color: $navy--300; + color: $navy--100; + } } } From f565594c27c4378d318c9a4df06946625b58246a Mon Sep 17 00:00:00 2001 From: Resaki1 Date: Wed, 15 Jan 2025 11:37:14 +0100 Subject: [PATCH 04/11] changed tooltip of disabled vote buttons --- .../Votes/VoteButtons/AddVoteButton.tsx | 11 ++++++++-- src/components/Votes/Votes.tsx | 22 ++++++++++++++++++- src/i18n/de/translation.json | 4 +++- src/i18n/en/translation.json | 4 +++- 4 files changed, 36 insertions(+), 5 deletions(-) diff --git a/src/components/Votes/VoteButtons/AddVoteButton.tsx b/src/components/Votes/VoteButtons/AddVoteButton.tsx index 6c12eade95..7f570a0e92 100644 --- a/src/components/Votes/VoteButtons/AddVoteButton.tsx +++ b/src/components/Votes/VoteButtons/AddVoteButton.tsx @@ -9,9 +9,10 @@ import {addVote} from "store/features"; type AddVoteProps = { noteId: string; disabled: boolean; + disabledReason?: string; }; -export const AddVoteButton: FC = ({noteId, disabled}) => { +export const AddVoteButton: FC = ({noteId, disabled, disabledReason}) => { const dispatch = useAppDispatch(); const {t} = useTranslation(); @@ -20,7 +21,13 @@ export const AddVoteButton: FC = ({noteId, disabled}) => { }; return ( - + ); diff --git a/src/components/Votes/Votes.tsx b/src/components/Votes/Votes.tsx index 37f304c5f9..c64e47921b 100644 --- a/src/components/Votes/Votes.tsx +++ b/src/components/Votes/Votes.tsx @@ -1,4 +1,5 @@ import {FC} from "react"; +import {useTranslation} from "react-i18next"; import classNames from "classnames"; import _ from "underscore"; import {useAppSelector} from "store"; @@ -13,6 +14,8 @@ type VotesProps = { }; export const Votes: FC = (props) => { + const {t} = useTranslation(); + const voting = useAppSelector((state) => state.votings.open); const ongoingVotes = useAppSelector( (state) => ({ @@ -31,6 +34,19 @@ export const Votes: FC = (props) => { const isModerator = useAppSelector((state) => ["OWNER", "MODERATOR"].some((role) => role === state.participants!.self?.role)); const boardLocked = useAppSelector((state) => state.board.data!.isLocked); + const addVotesDisabledReason = (): string => { + if (!voting) return ""; + + if (ongoingVotes.total === voting.voteLimit) { + return t("Votes.VoteLimitReached"); + } + if (ongoingVotes.note > 0 && !voting.allowMultipleVotes) { + return t("Votes.MultipleVotesNotAllowed"); + } + + return ""; + }; + /** * If there's no active voting going on and there are no casted votes for * this note from previous votings, we don't need to render anything. @@ -46,7 +62,11 @@ export const Votes: FC = (props) => { {/* display for votes when voting is open */} {voting && ongoingVotes.note > 0 && } {voting && (isModerator || !boardLocked) && ( - 0 && !voting.allowMultipleVotes)} /> + 0 && !voting.allowMultipleVotes)} + disabledReason={addVotesDisabledReason()} + /> )} ) : null; diff --git a/src/i18n/de/translation.json b/src/i18n/de/translation.json index ae9c812c34..e286bdb4df 100644 --- a/src/i18n/de/translation.json +++ b/src/i18n/de/translation.json @@ -673,7 +673,9 @@ "AddVote": "Stimme hinzufügen", "RemoveVote": "Stimme entfernen", "VotesOnNote_one": "{{count}} Stimme", - "VotesOnNote_other": "{{count}} Stimmen" + "VotesOnNote_other": "{{count}} Stimmen", + "VoteLimitReached": "Maximale Anzahl an Stimmen erreicht", + "MultipleVotesNotAllowed": "Mehrfachabstimmung nicht erlaubt" }, "Snowfall": { "toastTitle": "Frohe Feiertage 🎄", diff --git a/src/i18n/en/translation.json b/src/i18n/en/translation.json index 5bb94845ba..282c8ad9d5 100644 --- a/src/i18n/en/translation.json +++ b/src/i18n/en/translation.json @@ -673,7 +673,9 @@ "AddVote": "Add vote", "RemoveVote": "Remove vote", "VotesOnNote_one": "{{count}} vote", - "VotesOnNote_other": "{{count}} votes" + "VotesOnNote_other": "{{count}} votes", + "VoteLimitReached": "Maximum number of votes reached", + "MultipleVotesNotAllowed": "Multiple votes are not allowed" }, "Snowfall": { "toastTitle": "Happy Holidays 🎄", From 29d4e701ca3951a93c14c4b9b06799ae917de2cd Mon Sep 17 00:00:00 2001 From: Resaki1 Date: Wed, 15 Jan 2025 12:25:39 +0100 Subject: [PATCH 05/11] adjusted colors of note buttons --- .../NoteDialogDeleteNoteButton.scss | 4 +-- .../NoteDialogNoteOptions.scss | 26 +++++-------------- .../NoteDialogNoteOptions.tsx | 2 +- .../Votes/VoteButtons/AddVoteButton.scss | 6 ++--- .../Votes/VoteButtons/RemoveVoteButton.scss | 6 ++--- 5 files changed, 15 insertions(+), 29 deletions(-) diff --git a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogDeleteNoteButton.scss b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogDeleteNoteButton.scss index 7fcfe1e392..97cbdd6c18 100644 --- a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogDeleteNoteButton.scss +++ b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogDeleteNoteButton.scss @@ -7,9 +7,7 @@ display: flex; justify-content: center; align-items: center; - // no background - background-color: transparent !important; - color: var(--accent-color--light); + color: var(--accent-color--600); transition: background-color 150ms ease-in-out, color 150ms ease-in-out; diff --git a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.scss b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.scss index 4b2053eb77..060823ca90 100644 --- a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.scss +++ b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.scss @@ -19,16 +19,13 @@ width: 32px; padding: 0; border: 0; - color: var(--accent-color--light); - background-color: var(--accent-color--100); + color: var(--accent-color--600); + background-color: transparent; border-radius: $rounded--full; cursor: pointer; transition: background-color 80ms ease-in-out, color 80ms ease-in-out; - box-shadow: - 0 1px 3px 0 rgba(var(--accent-color--light-rgb), 0.1), - 0 1px 2px -1px rgba(var(--accent-color--light-rgb), 0.1); > svg { height: 100%; @@ -36,33 +33,24 @@ } &:hover { - background-color: var(--accent-color--light); - color: $gray--000; + color: var(--accent-color--500); } + &:focus-visible { outline: 2px solid var(--accent-color--light); } - - &--secondary { - background-color: transparent; - box-shadow: none; - } } [theme="dark"] { .note-option__button { - background-color: rgba(var(--accent-color--dark-rgb), 0.6); - color: var(--accent-color--dark); + color: var(--accent-color--400); &:hover { - color: $gray--000; + color: var(--accent-color--300); } + &:focus-visible { outline: 2px solid rgba(var(--accent-color--dark-rgb), 0.6); } - - &--secondary { - background-color: transparent; - } } } diff --git a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.tsx b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.tsx index 6a7d415d93..f6f96673fd 100644 --- a/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.tsx +++ b/src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogOptions/NoteDialogNoteOptions.tsx @@ -79,7 +79,7 @@ export const NoteDialogNoteOptions: FC = (props: Not props.isStackedNote || !props.hasStackedNotes || !allowedToDeleteStack ? t("NoteDialogDeleteNoteButton.title") : t("NoteDialogDeleteStackButton.title") } aria-label={props.isStackedNote || !props.hasStackedNotes || !allowedToDeleteStack ? t("NoteDialogDeleteNoteButton.title") : t("NoteDialogDeleteStackButton.title")} - className="note-option__button note-option__button--secondary" + className="note-option__button" onClick={() => { onDelete(props.noteId); }} diff --git a/src/components/Votes/VoteButtons/AddVoteButton.scss b/src/components/Votes/VoteButtons/AddVoteButton.scss index 8a860ed44b..43f38a35ea 100644 --- a/src/components/Votes/VoteButtons/AddVoteButton.scss +++ b/src/components/Votes/VoteButtons/AddVoteButton.scss @@ -10,7 +10,7 @@ width: 32px; background-color: var(--accent-color--100); - color: var(--accent-color--light); + color: var(--accent-color--600); transition: background-color 80ms ease-in-out, color 80ms ease-in-out; @@ -39,8 +39,8 @@ [theme="dark"] { .vote-button-add { - background-color: rgba(var(--accent-color--dark-rgb), 0.6); - color: var(--accent-color--dark); + color: var(--accent-color--500); + background-color: rgba(var(--accent-color--400-rgb), 0.24); &:enabled:hover { background-color: var(--accent-color--dark); diff --git a/src/components/Votes/VoteButtons/RemoveVoteButton.scss b/src/components/Votes/VoteButtons/RemoveVoteButton.scss index 66391a3bd5..dab03a0b47 100644 --- a/src/components/Votes/VoteButtons/RemoveVoteButton.scss +++ b/src/components/Votes/VoteButtons/RemoveVoteButton.scss @@ -10,7 +10,7 @@ align-items: center; overflow: hidden; background-color: var(--accent-color--100); - color: var(--accent-color--light); + color: var(--accent-color--600); transition: background-color 80ms ease-in-out, color 80ms ease-in-out; @@ -88,8 +88,8 @@ [theme="dark"] { .vote-button-remove { - color: $gray--000; - background-color: rgba(var(--accent-color--dark-rgb), 0.6); + color: var(--accent-color--500); + background-color: rgba(var(--accent-color--400-rgb), 0.24); &:enabled:hover { background-color: var(--accent-color--dark); From a2f1f655710b169262cb8d7412def1e45d54cff4 Mon Sep 17 00:00:00 2001 From: Resaki1 Date: Wed, 15 Jan 2025 14:36:16 +0100 Subject: [PATCH 06/11] fixed tests --- .../__tests__/__snapshots__/Column.test.tsx.snap | 12 +++++++++--- src/components/DotButton/DotButton.tsx | 3 +-- src/components/Votes/__tests__/Votes.test.tsx | 16 ++++++++++------ .../__tests__/__snapshots__/Votes.test.tsx.snap | 16 ++++++++++++---- 4 files changed, 32 insertions(+), 15 deletions(-) diff --git a/src/components/Column/__tests__/__snapshots__/Column.test.tsx.snap b/src/components/Column/__tests__/__snapshots__/Column.test.tsx.snap index 2d1d707a0e..88891f57de 100644 --- a/src/components/Column/__tests__/__snapshots__/Column.test.tsx.snap +++ b/src/components/Column/__tests__/__snapshots__/Column.test.tsx.snap @@ -570,8 +570,10 @@ exports[`Column should have correct style show column with correct style 1`] = ` role="none" >