You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a maintainer, I'd like to use the last versions of function to update target values for unit tests, so that I can update my source database without breaking the package
Success criteria
If I update my database, I can update the targets values of the unit tests with a single source()
After both updates, the package should pass all unit tests accordingly
Technical how
Current behaviour
Target values for page 4 unit tests is currently based on file "data-raw/altas_simulation.R"
If I source("data-raw/altas_simulation.R"), all target outputs are updated for unit tests.
Why is this a problem ?
The current "data-raw/altas_simulation.R" is based on the first version of R scripts provided by the client. After code rework, ThinkR wanted to be sure they could reproduce the same outputs as the client. This has been treated and validated through this issue: #19
Today, fix and improvments of the core of the models are directly made in the functions of the package. This means that outputs can (will) differ from original code on purpose. Hence, we need "data-raw/altas_simulation.R" to be up-to-date with the last version of models.
What to do?
Modify the content of this "data-raw/altas_simulation.R" file to directly use the functions of the package. Hence, if the core is changed, the outputs are also changed accordingly.
Warn the developer about this update, because they first need to be sure the outputs are the one really targeted, before updating the targets. To do so, they can use the vignette in "data-raw/be-page4-future.Rmd" to explore the outputs of the model, before running and updated unit tests.
The text was updated successfully, but these errors were encountered:
As a maintainer, I'd like to use the last versions of function to update target values for unit tests, so that I can update my source database without breaking the package
Success criteria
source()
Technical how
Current behaviour
source("data-raw/altas_simulation.R")
, all target outputs are updated for unit tests.Why is this a problem ?
The current "data-raw/altas_simulation.R" is based on the first version of R scripts provided by the client. After code rework, ThinkR wanted to be sure they could reproduce the same outputs as the client. This has been treated and validated through this issue: #19
Today, fix and improvments of the core of the models are directly made in the functions of the package. This means that outputs can (will) differ from original code on purpose. Hence, we need "data-raw/altas_simulation.R" to be up-to-date with the last version of models.
What to do?
The text was updated successfully, but these errors were encountered: