Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "data-raw/altas_simulation.R" to use internal functions #138

Open
1 task
statnmap opened this issue Jun 14, 2022 · 0 comments
Open
1 task

Change "data-raw/altas_simulation.R" to use internal functions #138

statnmap opened this issue Jun 14, 2022 · 0 comments
Assignees

Comments

@statnmap
Copy link
Collaborator

statnmap commented Jun 14, 2022

Validation

  • I can reproduce all dput() files of "altas_simulation.R" that finish in the "tests/" from "data-raw/be-page4-future.Rmd"

Technicals

  • Réaliser l'exploration dans le Rmd correspondant dans "data-raw/be-page4-future.Rmd"
  • pkgload::load_all() pour tester ses effets
  • Mettre à jour les data dans les tests
    • Mettre à jour les datas de tests à partir du fichier Rmd et récupérer dans "altas_simulation.R" quels fichiers on a besoin : Rechercher les dput()

Note:

The creation of dput objects in "data-raw/altas_simulation.R" was necessary at the beginning of development to be sure outputs were consistent before and after packaging.
As of today (14 juin 2022), we consider outputs to be consistent.
We still need some dput object for unit tests, but we need to create a new version of "altas_simulation.R" that uses internal functions of the package, as they are now validated.
Then the user can decide when to update the dput, after modification of the functions of the package are validated.
This will avoid being forced to maintain two versions of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants