How to handle NSE arguments in construct_model(method.args) ?

[ddsjoberg]

I was working with a situation illustrated below that resulted in an error.

outside_fun <- function() {
  method.args <- list()
  
  construct_model.data.frame(
    mtcars, 
    formula = mpg ~ cyl,
    method = "lm", 
    method.args = method.args, 
    package = package
  )
}

outside_fun()

The original function that handles the potential NSE nature of method.args looked like this:

.as_list_of_exprs <- function(x) {
  call_args(enexpr(x))
}

I've added a small patch to this function, but it is not really how these things should be handled. I am not sure why the previous code was not working.

[ddsjoberg]

We would like to remove this tryCatch and still have everything work.

construct_helpers.R

.as_list_of_exprs <- function(x) {
  x_enexpr <- enexpr(x)
  browser()
  # if (tryCatch(inherits(x, "list"), error = \(x) FALSE)) {
  #   return(x)
  # }
  call_args(x_enexpr)
}

[ddsjoberg]

We can also add a check on the expression before we try to parse it. is_call_simple(x, ns = NULL) to have better error messaging

[thisisnic]

This was fixed by #179