-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG in R-devel for paired/unpaired tests #56
Comments
**What changes are proposed in this pull request?** * Style this entry in a way that can be copied directly into `NEWS.md`. (#<issue number>, @<username>) Provide more detail here as needed. **Reference GitHub issue associated with pull request.** _e.g., 'closes #<issue number>'_ closes #56 -------------------------------------------------------------------------------- Pre-review Checklist (if item does not apply, mark is as complete) - [ ] **All** GitHub Action workflows pass with a ✅ - [ ] PR branch has pulled the most recent updates from master branch: `usethis::pr_merge_main()` - [ ] If a bug was fixed, a unit test was added. - [ ] Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): `devtools::test_coverage()` - [ ] Request a reviewer Reviewer Checklist (if item does not apply, mark is as complete) - [ ] If a bug was fixed, a unit test was added. - [ ] Run `pkgdown::build_site()`. Check the R console for errors, and review the rendered website. - [ ] Code coverage is suitable for any new functions/features: `devtools::test_coverage()` When the branch is ready to be merged: - [ ] Update `NEWS.md` with the changes from this pull request under the heading "`# cards (development version)`". If there is an issue associated with the pull request, reference it in parentheses at the end update (see `NEWS.md` for examples). - [ ] **All** GitHub Action workflows pass with a ✅ - [ ] Approve Pull Request - [ ] Merge the PR. Please use "Squash and merge" or "Rebase and merge".
Hi, I am having this problem but the solution here proposed is not working for me; it gives me an error saying "val" is missing. Do you know why this could be or how to solve it? Thank you very much!! "We can update this pretty simply with a ... |> utils::modifyList(list(paired = NULL), keep.null = FALSE)" Error in modifyList(list(paired = NULL), keep.null = FALSE) : |
Dear @joanbirules , please open a new issue that includes a minimal reproducible example illustrating your issue (this includes both code and data we can run on our machines). Review https://reprex.tidyverse.org/ and learn how to create the example. |
What happened?
R-devel has an update where the
paired=
argument value from the formula method is not passed along to the default method.For example, we're currently using
t.test.formula()
for unpaired tests andt.test.default()
for paired test. For the unpaired test, we were passingpaired= FALSE
. But in R-devel the docs have been updated to indicate this arg is not passed to the default method AND (importantly) the function errors if thepaired
arg is populated with either TRUE or FALSE.Created on 2024-02-19 with reprex v2.1.0
We can update this pretty simply with a
... |> utils::modifyList(list(paired = NULL), keep.null = FALSE)
The text was updated successfully, but these errors were encountered: