Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom logger #370

Closed
tanis2000 opened this issue Mar 11, 2020 · 7 comments · Fixed by #371
Closed

Custom logger #370

tanis2000 opened this issue Mar 11, 2020 · 7 comments · Fixed by #371

Comments

@tanis2000
Copy link
Contributor

Is there any way to pass to the library a custom logger to use instead of the default "log" package?

@pmazzini
Copy link
Collaborator

This looks similar to what was discussed in #332.

Which packages are you interested in?

In the nclient4/6 packages you can pass a custom logger.

@tanis2000
Copy link
Contributor Author

@pmazzini thanks for the feedback. Right now I'm interested in the server4 package and eventually in the server6

@pmazzini
Copy link
Collaborator

Yes, we need to make something similar to what was done for the nclient4/nclient6 packages. Feel free to put up a PR :)

@tanis2000
Copy link
Contributor Author

@pmazzini I'd be happy to contribute that code but so far I noticed that the master branch is failing most of the tests. Should I branch from there or is there a branch with no broken tests at the moment? Or is it just a problem because I'm on macOS?

@pmazzini
Copy link
Collaborator

Yes, it is because of macOS #229 #318

@tanis2000
Copy link
Contributor Author

There you go, this should do the trick: #371
Please let me know if you see any issue with it.

@pmazzini
Copy link
Collaborator

Thanks for working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants