Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.ref rules don't use optimistic attrs #232

Open
dwwoelfel opened this issue Sep 18, 2024 · 1 comment
Open

data.ref rules don't use optimistic attrs #232

dwwoelfel opened this issue Sep 18, 2024 · 1 comment

Comments

@dwwoelfel
Copy link
Contributor

This can cause a transaction that creates the attrs referenced in the data.ref to fail with an error: Record not found: attr.

If we used optimistic attrs when evaluating the rules, then this wouldn't happen.

Other ideas:

  • Validate that the attrs referenced by data.ref exist before saving the rules
    • But then you'd also have to have some mechanism to alert the developer if they changed attrs in a way that broke the rules.
@nezaj
Copy link
Contributor

nezaj commented Sep 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants