From 6b79696e0caa86cec8fd97be5cb4f59a3fb5b7fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20M=C3=BCller?= Date: Wed, 15 Jun 2022 16:59:36 +0200 Subject: [PATCH] Drop migrations using `SampleTransfer` These data migrations are unnecessary and conflict with the removal of the `SampleTransfer` model. --- ...ange_sample_transfers_requires_transfer_package.rb | 11 ----------- ...505070823_add_confirmed_at_to_transfer_packages.rb | 9 --------- 2 files changed, 20 deletions(-) diff --git a/db/migrate/20220412181435_change_sample_transfers_requires_transfer_package.rb b/db/migrate/20220412181435_change_sample_transfers_requires_transfer_package.rb index 2508dfb64..65bccf538 100644 --- a/db/migrate/20220412181435_change_sample_transfers_requires_transfer_package.rb +++ b/db/migrate/20220412181435_change_sample_transfers_requires_transfer_package.rb @@ -1,16 +1,5 @@ class ChangeSampleTransfersRequiresTransferPackage < ActiveRecord::Migration def up - # Create packages for existing transfers - SampleTransfer.where(transfer_package_id: nil).find_each do |transfer| - package = TransferPackage.create( - sender_institution_id: transfer.sender_institution_id, - receiver_institution_id: transfer.receiver_institution_id, - ) - transfer.update_columns( - transfer_package_id: package.id, - ) - end - change_column_null :sample_transfers, :transfer_package_id, false end diff --git a/db/migrate/20220505070823_add_confirmed_at_to_transfer_packages.rb b/db/migrate/20220505070823_add_confirmed_at_to_transfer_packages.rb index f93a14960..ab71b8d3b 100644 --- a/db/migrate/20220505070823_add_confirmed_at_to_transfer_packages.rb +++ b/db/migrate/20220505070823_add_confirmed_at_to_transfer_packages.rb @@ -4,15 +4,6 @@ def up add_index :transfer_packages, :confirmed_at TransferPackage.reset_column_information - - # Fill confirmed_at on existing packages if their sample transfers have been confirmed - TransferPackage.find_each do |package| - if confirmed_at = package.sample_transfers.map(&:confirmed_at).compact.max - package.update_columns( - confirmed_at: confirmed_at, - ) - end - end end def down