Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace whenever gem with a sidekiq plugin #1892

Open
ysbaddaden opened this issue Feb 2, 2023 · 1 comment · May be fixed by #1893
Open

Replace whenever gem with a sidekiq plugin #1892

ysbaddaden opened this issue Feb 2, 2023 · 1 comment · May be fixed by #1893

Comments

@ysbaddaden
Copy link
Contributor

The whenever gem doesn't fit so well into a Docker environment: it depends on the crontab, must be reconfigured on each application restart, and so on. I'm not even sure the crontab actually ever runs in the container (we only update the crontab, there is cron daemon service running), so I'm not sure the temporarily uploaded assay files are ever being cleaned up.

It would also simplify the Docker images: no need to install cron, to run whenever --update-crontab, and so on.

We have a sidekiq service, and there are a couple of maintained plugins to use it for recurring jobs in addition to one time jobs:

I used 'em both. I recall I liked one more than the other, but I don't remember which.

@ysbaddaden
Copy link
Contributor Author

ysbaddaden commented Feb 2, 2023

Oh, we already have sidekiq-cron. Let's use it 🎉

@ysbaddaden ysbaddaden linked a pull request Feb 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant