Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INS-2426] [bug] Ensure Status Update Only Occurs on Successful GitHub and DVC Pulls #592

Closed
1 task done
tonywang10101 opened this issue Oct 27, 2023 · 1 comment
Closed
1 task done

Comments

@tonywang10101
Copy link
Contributor

tonywang10101 commented Oct 27, 2023

Is There an Existing Issue for This?

  • I have searched the existing issues

Project

Instill Model

Is your Proposal Related to a Problem?

In the code located at this line, there is an issue where even if the model download process fails, it incorrectly reports success. This issue results in the condition in the code: utils.HasModelWeightFile(config.Config.TritonServer.ModelStore, tritonModels) returning true.

As a consequence, the system keeps attempting to deploy the model repeatedly, but it never succeeds. To replicate this error, you can set your disk size limit to a value insufficient for a successful DVC pull of the full model. For example, if the model size is 15GB, but you only have 7GB of disk space available to run the image, this issue becomes apparent.

Describe Your Proposed Improvement

To resolve this problem, we need to ensure that failed DVC pulls or other errors do not incorrectly update the space status, and they should provide informative error messages instead.

Highlight the Benefits

No response

Anything Else?

No response

INS-2426

@tonywang10101 tonywang10101 changed the title [bug] Ensure Status Update Only Occurs on Successful GitHub and DVC Pulls [INS-2426] [bug] Ensure Status Update Only Occurs on Successful GitHub and DVC Pulls Oct 27, 2023
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
@pinglin pinglin transferred this issue from instill-ai/community May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant