Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: github_user logins is not returning all valid users #2505

Open
1 task done
julialawrence opened this issue Dec 6, 2024 · 3 comments
Open
1 task done

[BUG]: github_user logins is not returning all valid users #2505

julialawrence opened this issue Dec 6, 2024 · 3 comments
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@julialawrence
Copy link

julialawrence commented Dec 6, 2024

Expected Behavior

data "github_users" "all_users" {
  provider  = github
  usernames = local.user_list
}

should return the entire local.user_list between logins and unknown_logins

Actual Behavior

It appears to identify invalid users properly, but logins return way short of the input list minus unknown_logins

Terraform Version

Terraform v1.7.4
on darwin_amd64
+ provider registry.terraform.io/integrations/github v6.3.0

Affected Resource(s)

  • github_users

Terraform Configuration Files

data "github_users" "all_users" {
  usernames = local.user_list
}

Steps to Reproduce

No response

Debug Output

No response

Panic Output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@julialawrence julialawrence added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Dec 6, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active Dec 6, 2024
@stevehipwell
Copy link
Contributor

@julialawrence I'm not an expert on the resources or data sources in the provider being queried from the GraphQL endpoint but it looks like pagination hasn't been enabled for the query so I guess that might be the issue here?

@julialawrence
Copy link
Author

@stevehipwell that is my guess as well, however, as per https://registry.terraform.io/providers/integrations/github/latest/docs/data-sources/users which are the latest docs, there's neither an option to enable pagination nor a doc note to explain that the values returned might be incomplete due to it.

@stevehipwell
Copy link
Contributor

@julialawrence I think you'd need to work with the code rather than the docs in this case

@nickfloyd nickfloyd moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
None yet
Development

No branches or pull requests

2 participants