Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix artifact build #4137

Closed
terriko opened this issue May 21, 2024 · 1 comment
Closed

ci: fix artifact build #4137

terriko opened this issue May 21, 2024 · 1 comment
Labels
CI Related to our continuous integration service (GitHub Actions)
Milestone

Comments

@terriko
Copy link
Contributor

terriko commented May 21, 2024

It looks like what I did in #4126 was a bit too aggressive -- the artifact build isn't running on pull requests any more (hurray!) but now it's not running on anything. I think we'd like it to run on main and only main, and only run on the main intel/cve-bin-tool repo so I don't get messages about people's forks.

It's likely a typo or some other reasonably trivial fix, but it may be hard to find because debugging yml that runs only on main is the worst. If you intend to work on this, you'll probably want to take the repo name check out so you can test it on your fork, then put it back in just before making a PR.

@terriko terriko added the CI Related to our continuous integration service (GitHub Actions) label May 21, 2024
@terriko terriko added this to the future milestone May 21, 2024
@terriko
Copy link
Contributor Author

terriko commented Aug 7, 2024

This is fixed now

@terriko terriko closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Related to our continuous integration service (GitHub Actions)
Projects
None yet
Development

No branches or pull requests

1 participant