Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question: can self-dlopen() be eliminated #61

Open
dvrogozh opened this issue Apr 5, 2019 · 0 comments
Open

question: can self-dlopen() be eliminated #61

dvrogozh opened this issue Apr 5, 2019 · 0 comments

Comments

@dvrogozh
Copy link
Contributor

dvrogozh commented Apr 5, 2019

As highlighted in #60, opencl-clang dlopen() itself to get some symbol addresses via dlsym(). Can this be avoided? Why we can't get address at compile/linkage time?

dlopen() is called here:

opencl-clang/pch_mgr.cpp

Line 170 in 325cbb5

void *handle = dlopen(lib, RTLD_NOW);

Library name to load is set here:

opencl-clang/CMakeLists.txt

Line 147 in 325cbb5

add_definitions( -DLIBCOMMON_CLANG_NAME="lib${COMMON_CLANG_LIBRARY_NAME}.so")

@dvrogozh dvrogozh mentioned this issue Apr 5, 2019
Closed
dvrogozh added a commit to dvrogozh/opencl-clang that referenced this issue Apr 13, 2019
@dvrogozh
Refactor work with opencl-c.h resource file
fa5afef 
There is no need to work with opencl-c.h file as with the resource.
Instead we just can directly link against its representation as a c-array.

Fixes: intel#61

Signed-off-by: Dmitry Rogozhkin <[email protected]>
@dvrogozh dvrogozh mentioned this issue Apr 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dvrogozh