Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bother rsyncing if VSCode sync-rsync.remotePath is empty #5

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

DuncanDHall
Copy link
Contributor

Sorry, one last touch which makes VSCode see an exit 0 from vsync if we don't intend to rsync and signal that by setting sync-rsync.remotePath to ""

@traceypooh
Copy link
Contributor

ok, TY!
[optional!]

would you mind doing something like prepending the commit message as a comment to this (or some explaining comment) since lol, i'm not sure i understand it visually and feel like i'll trip/freeze on that at some later date? :p

@traceypooh
Copy link
Contributor

TY!!

@traceypooh traceypooh merged commit f533eba into internetarchive:main Feb 27, 2025
@DuncanDHall
Copy link
Contributor Author

Yes! You're absolutely right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants