Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync: don't log "fatal" errors when nothing is really wrong #562

Open
isc-tleavitt opened this issue Oct 22, 2024 · 0 comments
Open

Sync: don't log "fatal" errors when nothing is really wrong #562

isc-tleavitt opened this issue Oct 22, 2024 · 0 comments
Labels
customer Based on customer feedback (as opposed to something identified by developers) enhancement New feature or request usability

Comments

@isc-tleavitt
Copy link
Collaborator

Example:

Syncing local repository...

Fetch done
Pulling from branch: test-reload-behavior
fatal: couldn't find remote ref test-reload-behavior


Nothing to compile.

fatal: couldn't find remote ref test-reload-behavior

Pull ran with return code: 1
remote: 
remote: To create a merge request for test-reload-behavior, visit:        
remote:   https://scm.dev.isccloud.io/appservices/appservices/-/merge_requests/new?merge_request%5Bsource_branch%5D=test-reload-behavior        
remote: 
To [https://scm.dev.isccloud.io/appservices/appservices.git](https://scm.dev.isccloud.io/appservices/appservices.git%3Cbr%3E)
 * [new branch]      test-reload-behavior -> test-reload-behavior

Current branch test-reload-behavior is up to date.

Nothing to compile.
Everything up-to-date

In this case, the fact that the remote ref can't be found is actually totally fine. We shouldn't log errors about it as a nontechnical user (or even a technical user) might be reasonably scared by seeing "fatal" in a log!

(A user noted this and I've just seen it again.)

@isc-tleavitt isc-tleavitt added enhancement New feature or request customer Based on customer feedback (as opposed to something identified by developers) usability labels Oct 22, 2024
@isc-tleavitt isc-tleavitt added this to the Q3/Q4 2024 Targets milestone Oct 22, 2024
@isc-tleavitt isc-tleavitt self-assigned this Oct 25, 2024
@isc-tleavitt isc-tleavitt removed their assignment Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer Based on customer feedback (as opposed to something identified by developers) enhancement New feature or request usability
Projects
None yet
Development

No branches or pull requests

1 participant