Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink deletes with "Remove from Source Control" option #581

Open
isc-pbarton opened this issue Oct 25, 2024 · 3 comments
Open

Rethink deletes with "Remove from Source Control" option #581

isc-pbarton opened this issue Oct 25, 2024 · 3 comments
Assignees
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)

Comments

@isc-pbarton
Copy link
Collaborator

The "Remove from Source Control" option in the source control menu will delete the file from the Git repository. There should at least be a confirmation dialog before doing this delete. Potentially this option should not be available in Basic Mode. And perhaps removing an item from source control should not actually delete something from the Git repository, just remove it from tracking in IRIS.

@isc-pbarton isc-pbarton self-assigned this Oct 25, 2024
@isc-tleavitt
Copy link
Collaborator

Related to #455 - we missed the target on the original fix, though there's still value in what was done there.

@isc-tleavitt isc-tleavitt added bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers) labels Oct 25, 2024
@isc-tleavitt
Copy link
Collaborator

I think it could also be on the table to remove this menu item entirely. A broader consideration could be how this extension plays alongside .gitignore files (could be edited via the web application, or maybe managed through a UI somewhere eventually?)

@isc-tleavitt isc-tleavitt added this to the Q3/Q4 2024 Targets milestone Oct 30, 2024
@isc-pbarton
Copy link
Collaborator Author

Gitignore management has been rolled into a separate issue: #630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)
Projects
None yet
Development

No branches or pull requests

2 participants