Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dss] Implicit subscriptions for OIRs are only extended, never shrunk #1101

Open
Shastick opened this issue Sep 6, 2024 · 0 comments
Open
Labels
bug Software behaves incorrectly because of this issue dss Relating to one of the DSS implementations feature Issue would improve software P3 Lower priority

Comments

@Shastick
Copy link
Contributor

Shastick commented Sep 6, 2024

Describe the bug

When an OIR is created with parameters that specify an existing implicit subscription,
that subscription's extent will be extended as required to cover the OIR

There is no corresponding mechanism that would shrink the subscription to smallest possible extend when an OIR is deleted, and the implicit subscription it was depending on has other dependent OIRs.

To reproduce

Given t0 < t1 < t2:

  • create OIR A from time t0 to t1 and request an implicit subscription which we'll call IS1
  • IS1 now goes from t0 to t1
  • create an OIR B from t1 to t2 that relies on subscription IS1
  • IS1 now goes from t0 to t2
  • delete OIR A
  • IS1 still goes from t0 to t2

Difference from expected behavior

The expected behavior is that after deleting OIR A, the implicit subscription should have been shrunk to only cover t1 to t2.

Possible solution

Extend the cleanup logic being added with #1056 to shrink a subscription, is possible, when a dependent OIR is being removed.

Notes

Given that the subscription covers all existing OIRs, the only downside of this bug is that a USS may received notifications that are not relevant anymore.

A mitigation for this is for a USS to either let the DSS manage one implicit subscription per OIR or to manage its subscriptions itself.

@Shastick Shastick added P3 Lower priority bug Software behaves incorrectly because of this issue feature Issue would improve software dss Relating to one of the DSS implementations labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software behaves incorrectly because of this issue dss Relating to one of the DSS implementations feature Issue would improve software P3 Lower priority
Projects
None yet
Development

No branches or pull requests

1 participant