We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The following PubMed ID is not correctly detected because it is also a valid EAN8 number: https://www.ncbi.nlm.nih.gov/pubmed/?term=26037202
>>> import idutils >>> idutils.is_pmid('26037202') <_sre.SRE_Match at 0x10b774608> >>> idutils.detect_identifier_schemes('26037202') ['ean8’] >>> idutils.detect_identifier_schemes('pmid:26037202') ['pmid']
I think the main problems is when scheme detection is used together with normalisation:
>>> idutils.normalize_pmid('pmid:26037202') '26037202' >>> idutils.detect_identifier_schemes(idutils.normalize_pmid('pmid:26037202')) ['ean8'] >>> idutils.detect_identifier_schemes('pmid:26037202') ['pmid']
I would propose that we change PubMed normalisation to include pmid: prefix so that the following holds true:
pmid:
idutils.detect_identifier_schemes(idutils.normalize_pmid('pmid:26037202')) == idutils.detect_identifier_schemes('pmid:26037202')
This is not strictly correct, but having just integers as identifiers is a bad idea anyway.
The text was updated successfully, but these errors were encountered:
lnielsen
No branches or pull requests
The following PubMed ID is not correctly detected because it is also a valid EAN8 number:
https://www.ncbi.nlm.nih.gov/pubmed/?term=26037202
I think the main problems is when scheme detection is used together with normalisation:
I would propose that we change PubMed normalisation to include
pmid:
prefix so that the following holds true:This is not strictly correct, but having just integers as identifiers is a bad idea anyway.
The text was updated successfully, but these errors were encountered: