Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render comments associated with events as a unit rather than separately #420

Open
max-moser opened this issue Jan 9, 2025 · 0 comments
Open

Comments

@max-moser
Copy link
Contributor

At TUW, we recently got feedback that it's slightly confusing to users that the comments that are written alongside request actions (e.g. "accept with comment") are rendered as two separate units in request detail pages.
On first glance, that takes away from the fact that they're actually one thing.

Context

When looking a the request's timeline in the API, there are several types of events; the relevant ones here being a LogEventType and a CommentEventType.
The first one marks the "accept" action being performed, the second contains the comment that was sent off along with the action.

It seems like there is currently no link between the two timeline events, which makes it hard to correlate them and also to render them together.

Perhaps we could introduce an optional link (via ID?) in the payload for comment events that tie them to their corresponding log event (if one exists)?
This could make it relatively simple for the UI to render them together as a single unit.

Current rendering

image

Expected rendering (example)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant