Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize ui endpoints #443

Open
NRodriguezcuellar opened this issue Mar 7, 2022 · 0 comments
Open

Centralize ui endpoints #443

NRodriguezcuellar opened this issue Mar 7, 2022 · 0 comments

Comments

@NRodriguezcuellar
Copy link

We should avoid hardcoding ui endpoints in the components.

for example: https://github.com/inveniosoftware/react-invenio-deposit/pull/424/files#diff-43aa1e4e0a4bae4497587329b9127e93d77f0cb31676abe21ceaebebb1fe7df1R41

possible ideas:

  • Passing them as a prop to CommunitySelection from the header, which subsequently receives it as a prop from RDM
  • Better but bigger solution: Pass deposit links config in the deposit form app from RDM and store it in deposit redux so it can be consumed globally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NRodriguezcuellar