-
-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Include preact with static #4937
Comments
@inventree/triage opinions? 👍 / 👎 |
I would strongly be about providing the complete source code for preact. I'm not sure if every company allows external requests to CDNs or even has an internet connection. And in your description, I guess you mean htm right? |
@matmair is preact a viable alternative to react for our purposes? Also, if a plugin requires preact, can't it just load it from a CDN? It'll be cached anyway right? |
@SchrodingersGat for inserting small interactive elements into the UI yes. It works very nicely with the current setup. See Lukas bulk plugin for example. The problem I am running into is the following: the new inventree-kom2 plugin will include preact and htm; Lukas plugin also includes those files - this leads to potential overloading of the namespace (with panels for example). Making things unstable. |
Closing in favour of #5011 |
Please verify that this feature request has NOT been suggested before.
Problem statement
Currently, every plugin needs to include their own version of preact and htm.
Suggested solution
Include https://esm.sh/htm/preact/standalone as a static file.
Describe alternatives you've considered
Vanilla js works, preact feels more intuitive.
Examples of other systems
No response
Do you want to develop this?
The text was updated successfully, but these errors were encountered: