From bf71d3ca36a06b5f5c25bb2af5cea3f7b3edf572 Mon Sep 17 00:00:00 2001 From: HassanBahati Date: Sun, 1 Dec 2024 15:16:33 +0300 Subject: [PATCH 1/7] chore: ignore firebase cache --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 0b50e408..2f755392 100644 --- a/.gitignore +++ b/.gitignore @@ -10,3 +10,6 @@ dist functions/lib/**/*.js functions/lib/**/*.js.map + +# Firebase cache +.firebase/ \ No newline at end of file From ffc8cf05ceb6a9df0243d93be5ad8e72b8c979cb Mon Sep 17 00:00:00 2001 From: HassanBahati Date: Sun, 1 Dec 2024 20:16:35 +0300 Subject: [PATCH 2/7] tests: disable file parallelism to solve race conditions --- vitest.config.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/vitest.config.ts b/vitest.config.ts index 979ab50d..575c4776 100644 --- a/vitest.config.ts +++ b/vitest.config.ts @@ -3,6 +3,7 @@ import path from "path"; export default defineConfig({ test: { + fileParallelism: false, coverage: { provider: "istanbul", }, From 9162d7ab9ca2e34737c587fe78c96684bedd68c0 Mon Sep 17 00:00:00 2001 From: HassanBahati Date: Sun, 1 Dec 2024 20:22:58 +0300 Subject: [PATCH 3/7] chore: upgrade firebase-emulator-action to v1.0.1 --- .github/workflows/tests.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index af155fa6..c77f1177 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -5,6 +5,7 @@ on: branches: - next pull_request: + - next jobs: test: @@ -32,7 +33,7 @@ jobs: run: pnpm install - name: Start Firebase Emulator Suite - uses: firebase-emulator-action@v1 + uses: firebase-emulator-action@v1.0.1 # Determine which packages have changed - name: Determine changed packages From 2e52626e69bdc91df3daa64b21f6819971f48c6d Mon Sep 17 00:00:00 2001 From: HassanBahati Date: Sun, 1 Dec 2024 20:25:04 +0300 Subject: [PATCH 4/7] chore: Upgrade invertase/firebase-emulator-action to v1.0.1 --- .github/workflows/tests.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index c77f1177..84b37057 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -33,7 +33,7 @@ jobs: run: pnpm install - name: Start Firebase Emulator Suite - uses: firebase-emulator-action@v1.0.1 + uses: invertase/firebase-emulator-action@v1.0.1 # Determine which packages have changed - name: Determine changed packages From def47f0ea3c7a702667c40f46c9566489f9d1908 Mon Sep 17 00:00:00 2001 From: HassanBahati Date: Sun, 1 Dec 2024 20:32:19 +0300 Subject: [PATCH 5/7] fix: remove unknown annotation --- .github/workflows/tests.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index 84b37057..a4604656 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -5,6 +5,7 @@ on: branches: - next pull_request: + branches: - next jobs: From abc50bbf094997d51809bbe8f0da2737b4336029 Mon Sep 17 00:00:00 2001 From: HassanBahati Date: Sun, 1 Dec 2024 20:45:07 +0300 Subject: [PATCH 6/7] chore: rename FirestoreUseMutationOptions=> FirestoreUseMutationOptions --- .../src/firestore/useClearIndexedDbPersistenceMutation.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react/src/firestore/useClearIndexedDbPersistenceMutation.ts b/packages/react/src/firestore/useClearIndexedDbPersistenceMutation.ts index 91b7e3eb..c104abbc 100644 --- a/packages/react/src/firestore/useClearIndexedDbPersistenceMutation.ts +++ b/packages/react/src/firestore/useClearIndexedDbPersistenceMutation.ts @@ -5,14 +5,14 @@ import { type FirestoreError, } from "firebase/firestore"; -type FirestoreUseMutationOptions = Omit< +type UseFirestoreMutationOptions = Omit< UseMutationOptions, "mutationFn" >; export function useClearIndexedDbPersistenceMutation( firestore: Firestore, - options?: FirestoreUseMutationOptions + options?: UseFirestoreMutationOptions ) { return useMutation({ ...options, From 898cb149c04815a6a0c13e8e686e953a1e8bb98f Mon Sep 17 00:00:00 2001 From: HassanBahati Date: Sun, 1 Dec 2024 20:58:13 +0300 Subject: [PATCH 7/7] ci(tests): verify running emulators --- .github/workflows/tests.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index a4604656..449d55f8 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -36,6 +36,10 @@ jobs: - name: Start Firebase Emulator Suite uses: invertase/firebase-emulator-action@v1.0.1 + - name: Verify Running Emulators + run: | + curl --silent http://localhost:4400/emulators | jq 'keys[]' + # Determine which packages have changed - name: Determine changed packages id: changes