Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging doesn't properly format message #20

Open
AlonSh opened this issue May 10, 2018 · 2 comments
Open

Logging doesn't properly format message #20

AlonSh opened this issue May 10, 2018 · 2 comments

Comments

@AlonSh
Copy link

AlonSh commented May 10, 2018

Hey,
I pass a logbook.Logger instance to the logger variable of retry:

@retry(exceptions=ConnectionError, tries=MAX_RETRIES, delay=RETRY_TIMEOUT, logger=logger)

And the matching logline I get is:

[2018-05-10 09:36:57.321720] WARNING: vector.core.file_collection.es_utils: %s, retrying in %s seconds...

(The %s are not properly formated)

Can you fix that?
thanks!

@cscetbon
Copy link

Any news on that ? @AlonSh maybe a PR if you made the change on your side ?

@AlonSh
Copy link
Author

AlonSh commented Mar 25, 2020

Any news on that ? @AlonSh maybe a PR if you made the change on your side ?

I think I've just kept using it that way, but I don't remember exactly and I do not have access to the relevant code anymore. It's not a difficult fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants