Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more proxmox tags to the vms #72

Open
firecyberice opened this issue Jan 22, 2024 · 2 comments
Open

Add more proxmox tags to the vms #72

firecyberice opened this issue Jan 22, 2024 · 2 comments
Labels
enhancement New feature or request kind/feature

Comments

@firecyberice
Copy link

firecyberice commented Jan 22, 2024

Describe the solution you'd like
Right now there are two tags present for the vms in proxmox:

  • go-proxmox+cloud-init (What is the value / reason of this?)
  • ip_net0_<the IP of the vm>

It would be nice to have additional tags / labels like:

  • clustername to identify the cluster of that node
  • mgmt cluster name or any other reference to the capi cluster that is managing this vm / workload cluster in case there are more management clusters on that proxmox environment.

Optional:
It would be nice to add custom tags as well (at least at some point in the future)

@firecyberice firecyberice added enhancement New feature or request kind/feature labels Jan 22, 2024
@mcbenjemaa
Copy link
Member

mcbenjemaa commented Jan 22, 2024

go-proxmox+cloud-init is needed to make sure, we unmount the cloudinit iso and destroy it, before deleting the machine.

we can probably remove it: #73

@mcbenjemaa
Copy link
Member

The unmount of cloud-init iso is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kind/feature
Projects
None yet
Development

No branches or pull requests

2 participants