-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quarterly glider metrics #4
Comments
Need to check my code against @kbailey-noaa Mine:
Kathy's:
|
Should be
|
@ocefpaf can I get some help with this at some point? I could never get cc: @kbailey-noaa |
@MathewBiddle gdutils was never packaged. See kerfoot/gdutils#2, kerfoot/gdutils#3, and kerfoot/gdutils#4. However, I do have a lockfile and a local clone that could make it work. With that said, we should probably build the necessary functionalities you all need into gliderpy. Let's chat a bit on slack and I can try to get that going ASAP. |
Can you check your functions against https://nbviewer.org/gist/ocefpaf/2f5a844d556a41b54f894e17541ec4db ? That is is "kind of" validated against |
using my script, which harvests dates from the global metadata on the glider erddap (https://gliders.ioos.us/erddap/tabledap/allDatasets.htmlTable?minTime%2CmaxTime%2CdatasetID): In your gist:
So, off by 100 days. That's a lot. |
The off by 100 is in your script, right? My guess is that it is b/c your are rounding days using the default in pandas instead of using floor/ceil for each start/end date. In my code that is I don't think your estimate is bad if you look at it from the point of view that you requested the minimum amount of metadata/data possible from the allDatasets in ERDDAP. It is an elegant and fast way to get an approximate answer. However, if I understood what John used to do and what Kathy needs, we should consider a glider that was in the water just a minute past midnight, as a new glider day, right? TL;DR IMO both are correct answers depending on the message we want to convey. |
Similar to the GTS calculations, it would be useful to have gliderDAC quarterly metrics too.
https://github.com/MathewBiddle/ioos_by_the_numbers/tree/main/gts
The text was updated successfully, but these errors were encountered: