Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New page deployed before merge #22

Open
julianstirling opened this issue Mar 7, 2020 · 3 comments
Open

New page deployed before merge #22

julianstirling opened this issue Mar 7, 2020 · 3 comments

Comments

@julianstirling
Copy link
Member

I made a merge request and the site seems to have already deployed!
@kasbah
Copy link
Member

kasbah commented Mar 8, 2020

Could you explain what you mean? Merge requests are built and deployed to a preview domain (e.g. https://okh-git-cardfix.kasbah.now.sh/) not the main domain. Is that a problem?

@julianstirling
Copy link
Member Author

When I checked https://search.openknowhow.org/ it seemed to me that my change was already there. Maybe, maybe I am mistaken?

@kasbah
Copy link
Member

kasbah commented Mar 9, 2020

Hm, yeah, really shouldn't be. Let's keep an eye on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kasbah @julianstirling