You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current Storage based signer (src/storage/storage_signer_owned.rs) is owned, which means that it will consume a storage given to it and trying to use the Storage afterward will run into null-pointer errors.
This has some impacts upon usage:
null-pointer errors are very un-TypeScript-ish to say the least, and will lead to errors most probably unexpected by implementers
avoiding these results in counterintuitive code and examples (e.g. a document has to be created before being allowed to create the identity client, as both need the storage, and the client (currently) takes ownership of it)
Storage signer should be reverted to a model where Storage is not consumed when creating the identity client in TypeScript.
The text was updated successfully, but these errors were encountered:
wulfraem
added
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
Wasm
Related to Wasm bindings. Becomes part of the Wasm changelog
labels
Feb 6, 2025
The current
Storage
based signer (src/storage/storage_signer_owned.rs
) is owned, which means that it will consume a storage given to it and trying to use theStorage
afterward will run into null-pointer errors.This has some impacts upon usage:
Storage signer should be reverted to a model where
Storage
is not consumed when creating the identity client in TypeScript.The text was updated successfully, but these errors were encountered: