Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Investigate using wasm-opt again with wasm-bindgen version 0.2.100 #1553

Open
wulfraem opened this issue Feb 26, 2025 · 0 comments
Open
Labels
Bug Something isn't working. Chore Tedious, typically non-functional change Wasm Related to Wasm bindings. Becomes part of the Wasm changelog

Comments

@wulfraem
Copy link
Contributor

Description

wasm-opt is has been deactivated with #1551, after bumping asm-bindgen to version 0.2.100 due to errors during tests. Investigate how we can enable it again in our WASM build setup.

Motivation

It would be good to try to keep the wasm files as small as possible, like before. ^^

Resources

Error messages that is thrown during tests (macOS 15.2):

npm run test:node                                                                                                                                                                                                                    0 (0.000s) < 09:45:59

> @iota/[email protected] test:node
> ts-mocha -r tsconfig-paths/register -p tsconfig.node.json ./examples/src/tests/*.ts --parallel --jobs 4 --retries 3 --timeout 180000 --exit



  1) Uncaught error outside test suite

  0 passing (477ms)
  1 failing

  1) Uncaught error outside test suite:
     Uncaught RangeError: WebAssembly.Table.grow(): failed to grow table by 4
      at module.exports.__wbindgen_init_externref_table (node/identity_wasm.js:14858:26)
      at null.<anonymous> (wasm://wasm/010827be:1:3336668)
      at Object.<anonymous> (node/identity_wasm.js:14967:6)
      at Module._compile (node:internal/modules/cjs/loader:1469:14)
      at Object.Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
      at Module.load (node:internal/modules/cjs/loader:1288:32)
      at Function.Module._load (node:internal/modules/cjs/loader:1104:12)
      at Module.require (node:internal/modules/cjs/loader:1311:19)
      at require (node:internal/modules/helpers:179:18)
      at Object.<anonymous> (lib/append_functions.ts:1:1)




  2) Uncaught error outside test suite

  3) Uncaught error outside test suite


(repeated until "13) ...")
@wulfraem wulfraem added Bug Something isn't working. Chore Tedious, typically non-functional change Wasm Related to Wasm bindings. Becomes part of the Wasm changelog labels Feb 26, 2025
@UMR1352 UMR1352 changed the title [Task] Investigate using was-opt again with wasm-bindgen version 0.2.100 [Task] Investigate using wasm-opt again with wasm-bindgen version 0.2.100 Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working. Chore Tedious, typically non-functional change Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Status: Product Backlog
Development

No branches or pull requests

2 participants