Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM: use wasm-bindgen unchecked_return_type to produce more idiomatic types #1554

Open
UMR1352 opened this issue Feb 26, 2025 · 0 comments
Open
Labels
Chore Tedious, typically non-functional change Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Wasm Related to Wasm bindings. Becomes part of the Wasm changelog

Comments

@UMR1352
Copy link
Contributor

UMR1352 commented Feb 26, 2025

Description

Replace complex types like UpdateDidProposalInternalTransactionOutput with TransactionOutput<Proposal<UpdateDid> | undefined>.

Motivation

wasm-bindgen doens't support generic types, which makes the generated code look very un-idiomatic.

@UMR1352 UMR1352 added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Chore Tedious, typically non-functional change Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tedious, typically non-functional change Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Status: Product Backlog
Development

No branches or pull requests

1 participant