Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several renamed types in iota_interaction_ts and iota_interaction_rust #1527

Open
wants to merge 3 commits into
base: feat/wasm32-identity-client
Choose a base branch
from
Open

Several renamed types in iota_interaction_ts and iota_interaction_rust #1527

wants to merge 3 commits into from

Conversation

chrisgitiota
Copy link

Description of change

This PR comprises the following renamings

bindings/wasm/iota_interaction_ts:

  • Renamed bindings::IotaTransactionBlockResponseAdapter to bindings::WasmIotaTxBlockResponseAdapter

identity_iota_core/src/iota_interaction_rust and
bindings/wasm/iota_interaction_ts:

  • Renamed AdapterNativeResponse to NativeTransactionBlockResponse

Links to any relevant issues

fixes issue #1514

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix
  • Refactoring (a non-breaking change which enhances code quality)

How the change has been tested

  • Current E2E tests for non wasm32 targets run but without success
  • Successfull wasm32 and non wasm32 build for identity_iota_core:
    wasm32 build: cargo build --package identity_iota_core --lib --target wasm32-unknown-unknown --no-default-features --features iota-client --features revocation-bitmap
  • NPM build iota_interaction_ts:
    In folder bindings/wasm/iota_interaction_ts:
    • npm install
    • npm run build:nodejs
  • NPM build identity_wasm:
    In folder bindings/wasm/identity_wasm:
    • Prerequisite: NPM build iota_interaction_ts (see above)
    • npm install
    • npm run build:nodejs

@chrisgitiota
Several renamed types in iota_interaction_ts and iota_interaction_rust
53a1c63 
bindings/wasm/iota_interaction_ts:
* Renamed `bindings::IotaTransactionBlockResponseAdapter`
  to `bindings::WasmIotaTxBlockResponseAdapter`

identity_iota_core/src/iota_interaction_rust and
bindings/wasm/iota_interaction_ts:
* Renamed `AdapterNativeResponse`
  to `NativeTransactionBlockResponse`
@chrisgitiota chrisgitiota added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Feb 13, 2025
@chrisgitiota chrisgitiota self-assigned this Feb 13, 2025
@chrisgitiota chrisgitiota requested a review from a team as a code owner February 13, 2025 08:46
@chrisgitiota chrisgitiota linked an issue Feb 14, 2025 that may be closed by this pull request
[Task] Make IotaTransactionBlockResponse related types exported from iota_interaction_ts and iota_interaction_rust easier to distinguish #1514
Open
@chrisgitiota
Renamed TS class IotaTransactionBlockResponseAdapter to `IotaTransa…
8eb80b3 
…ctionBlockResponseWrapper`

Additionall the WASM binding for `IotaTransactionBlockResponseAdapter` previously called `WasmIotaTxBlockResponseAdapter`, has been renamed to `WasmIotaTransactionBlockResponseWrapper`
@chrisgitiota
Merge branch 'feat/wasm32-identity-client' into feat/wasm32-identity-…
f4de491 
…client-some-type-renamings

# Conflicts:
#	bindings/wasm/identity_wasm/src/rebased/identity.rs
#	bindings/wasm/iota_interaction_ts/src/bindings/wasm_types.rs
#	bindings/wasm/iota_interaction_ts/src/iota_client_ts_sdk.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wulfraem wulfraem wulfraem requested changes

Assignees

@chrisgitiota chrisgitiota

Labels
No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Milestone
IID-E002: IOTA Identity (v1.6-alpha)
2 participants
@chrisgitiota @wulfraem