Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pull Upstream Changes but keep schemars #26

Closed
wants to merge 119 commits into from

Conversation

DaughterOfMars
Copy link
Contributor

Description

Pulls upstream changes as in #23 but excludes the removal of schemars implementations.

bmwill and others added 30 commits August 21, 2024 09:12
Add methods for Transaction and PersonalMessage for calculating the
signing digest which is used as the message to sign against in Sui.
Ignore the sui-graphql-client::test_object_query test since its has been
unreliable due to the dependency on an extrnal running network.
@Thoralf-M
Copy link
Member

CI fails

@DaughterOfMars
Copy link
Contributor Author

CI fails

I don't think it's ever succeeded?

@Thoralf-M
Copy link
Member

Thoralf-M commented Feb 21, 2025

I don't think it's ever succeeded?

It did at some point, but now it doesn't even compile, at least this should work

error: this file contains an unclosed delimiter
   --> crates/iota-sdk-types/src/hash.rs:379:3
    |
294 | impl crate::ObjectId {
    |                      - unclosed delimiter
...
301 |     pub fn derive_id(digest: crate::TransactionDigest, count: u64) -> Self {
    |                                                                            - this delimiter might not be properly closed...
...
336 | }
    | - ...as it matches this but it has different indentation
...
379 | }
    |  ^
    ```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.