From 88aba0c81c6d9e07fe6049eefd974418f8f8961f Mon Sep 17 00:00:00 2001
From: rafapereirabr <rafa.pereira.br@gmail.com>
Date: Mon, 22 Apr 2024 19:59:15 -0300
Subject: [PATCH] fix encoding issues in read_flights()

---
 DESCRIPTION | 2 +-
 NEWS.md     | 7 +++++++
 R/utils.R   | 7 +++++--
 3 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/DESCRIPTION b/DESCRIPTION
index fb5cef9..43fcf23 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: flightsbr
 Title: Download Flight and Airport Data from Brazil
-Version: 0.4.0
+Version: 0.4.09999
 Authors@R: 
     c(person(given="Rafael H. M.", family="Pereira", 
              email="rafa.pereira.br@gmail.com", 
diff --git a/NEWS.md b/NEWS.md
index d0d7717..831a631 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,3 +1,10 @@
+# flightsbr v0.4.1 dev
+
+* Minor changes:
+  * The `read_flights()` function now used `encoding = 'Latin-1'` internally to avoid issues with encoding. Closed #35.
+  * The function `get_airport_movement_dates_available()` does not throw warnings of `NA` values anymore.
+  
+
 # flightsbr v0.4.0
 
 * Major changes:
diff --git a/R/utils.R b/R/utils.R
index 579c549..1cf71e4 100644
--- a/R/utils.R
+++ b/R/utils.R
@@ -125,8 +125,10 @@ get_airport_movement_dates_available <- function(date=NULL) {
   csv_urls <- gsub('.csv.csv', '.csv', csv_urls, fixed = TRUE)
 
   # get all dates available
-  all_dates <- substr(csv_urls , (nchar(csv_urls ) + 1) -10, nchar(csv_urls )-4 )
+  all_dates <- regmatches(csv_urls, gregexpr("\\d{6}", csv_urls))
+  all_dates <- unlist(unique(all_dates))
   all_dates <- as.numeric(all_dates)
+
   return(all_dates)
 }
 
@@ -467,7 +469,8 @@ download_flights_data <- function(file_url = parent.frame()$file_url,
   dt <- data.table::fread( paste0(temp_local_dir,'/', file_name),
                            select = select,
                            colClasses = 'character',
-                           sep = ';')
+                           sep = ';',
+                           encoding = 'Latin-1')
 
   # return to original threads
   data.table::setDTthreads(orig_threads)