Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail on unknown codec / protocol #103

Open
lidel opened this issue Dec 16, 2022 · 0 comments
Open

Don't fail on unknown codec / protocol #103

lidel opened this issue Dec 16, 2022 · 0 comments
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization P2 Medium: Good to have, but can wait until someone steps up

Comments

@lidel
Copy link
Member

lidel commented Dec 16, 2022

Various commands return CID or Multiaddr instances.

For example, fetching ipfs.swarm.peers will return peers and their protocols.

The problem is that over time new codecs and protocols identified by new codes from this table appear, and software that uses older version of this library should not crash like it currently does.

Some examples: ipfs/ipfs-webui#2033, ipfs/ipfs-desktop#2363 (comment).

Solution

TBD, may require upstream changes to https://github.com/multiformats/js-multiaddr and https://github.com/multiformats/js-multiformats/, or maybe just ignoring (skipping) unsupported entries is enough?
@lidel lidel added P2 Medium: Good to have, but can wait until someone steps up kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Dec 16, 2022
This was referenced Dec 16, 2022
Merged
Closed
@whizzzkid whizzzkid mentioned this issue Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel