Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to read BCF #14

Open
mbhall88 opened this issue Aug 10, 2020 · 2 comments
Open

Add ability to read BCF #14

mbhall88 opened this issue Aug 10, 2020 · 2 comments

Comments

@mbhall88
Copy link
Member

As varifier uses pyfastaq to parse VCF it is unable to parse BCF format.

I know this is probably a big-ish change but I would suggest switching to using an API such as cyvcf2. This way the user doesn't have to convert all of their BCF files to VCF in order to use varifier. Additionally, cyvcf2 will likely give a decent speedup.

@mbhall88
Copy link
Member Author

As a temporary workaround, you can convert with bcftools and pipe into stdin of varifier

bcftools view -O v test.bcf \
| varifier vcf_eval truth.fasta ref.fasta - out_dir

@martinghunt
Copy link
Member

changing to cyvcf2 is a bigger change than I want to spend time doing. We could just have an open VCF function that pipes through bcftools if the file name ends with .bcf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants