Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_truth_vcf misses truth SNPs if they lie near dropped amplicons #37

Open
Danderson123 opened this issue Apr 6, 2022 · 3 comments
Open

Comments

@Danderson123
Copy link

Hey Martin!

I ntoiced a weird occurrence when running covid-truth-eval on artic assemblies built from simulated read sets, whereby a true SNP in the VCF of the artic assembly is incorrectly being identified as a false positive when it is actually present in the simulated assembly and therefore should be in the truth VCF. Turns out the SNP was in close proximity to a run of Ns in my simulated assemblies (to mask dropped amplicons) and was being missed by varifier make_truth_vcf. I have uploaded an example truth and artic assembly with the SNP, a truth VCF with the SNP missing and the output of covid-truth-eval.

Thanks and let me know if you need any more info,
varifier_example.tar.gz

Daniel

@martinghunt
Copy link
Member

Can you please list the commands I should run to reproduce this from your data, and what the SNP is that's causing the problems?

@Danderson123
Copy link
Author

Danderson123 commented Apr 21, 2022

Hey Martin,

The command I am running is singularity run singularity/varifier/varifier.img make_truth_vcf --global_align --global_align_min_coord 25 --global_align_max_coord 29827 masked_truth_assembly.fasta reference_genome.fasta truth_vcf/1_a and the SNP that is missed is 3037.

@martinghunt
Copy link
Member

Are you using MN908947.3 for reference_genome.fasta?

Position 3037 in MN908947.3 aligns inside a gap in masked_truth_assembly.fasta. Screenshot attached - 3037 is the C highlighted in the middle.

align
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants