Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move enum files to org.irods.operations package #78

Open
sam-i-am012 opened this issue Aug 8, 2024 · 12 comments
Open

Move enum files to org.irods.operations package #78

sam-i-am012 opened this issue Aug 8, 2024 · 12 comments
Assignees
Labels

Comments

@sam-i-am012
Copy link
Collaborator

No description provided.

@sam-i-am012 sam-i-am012 changed the title Put enum files in it's own folder Put enum files in it's own package Aug 8, 2024
@korydraughn
Copy link

What's the motivation for putting the enums in their own package?
How many enums are we talking about?

@sam-i-am012
Copy link
Collaborator Author

I think by the time I'm done with #41 it will be 5. It's currently under util but if that's fine then never mind.

@korydraughn
Copy link

What would the package name be?
What would the package contain? Please list the class/enum-type names.

@sam-i-am012
Copy link
Collaborator Author

Permission is used in collections and data objects endpoint
MetadataOperation is used in collections, data objects, resources, and users groups endpoint
UserType is used in users and groups endpoint
ZoneProperty is used in zones endpoint

I was thinking maybe naming it just enums or constants but that may be too vague.

@korydraughn
Copy link

What packages do we have in the project today? Please list them.

@sam-i-am012
Copy link
Collaborator Author

sam-i-am012 commented Aug 9, 2024

Operations
Properties
Serialize
Util

also I just realized I should rename these to be lowercase.

@korydraughn
Copy link

Yes, those should be lowercase. Good catch.

Given the enumerations are only used with operations, all enum source files can live in the org.irods.operations package.

I'm just now realizing that these packages need to be expanded to include at least a third/forth element (e.g. org.irods.http). I'll write up an issue for that.

@sam-i-am012
Copy link
Collaborator Author

I see that makes sense. Should I move the enums to org.irods.operations in this issue or does that need a new issue? Or should I just rename this issue?

@sam-i-am012
Copy link
Collaborator Author

properties should also probably be in the org.irods.operations package since it's only used with operations right?

@korydraughn
Copy link

Sounds like a good move to me.

What is properties? A package? An enum? A class?

@sam-i-am012
Copy link
Collaborator Author

Sorry, Properties is the package that contains all the classes for the methods that have more than one optional parameter.

@sam-i-am012 sam-i-am012 changed the title Put enum files in it's own package Move enum files to org.irods.operations package Aug 9, 2024
@korydraughn
Copy link

Let's hold on this issue for now. We need to think about this a little more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants