Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate iCommands builder from "core" builder #129

Open
alanking opened this issue Feb 23, 2024 · 4 comments
Open

Separate iCommands builder from "core" builder #129

alanking opened this issue Feb 23, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@alanking
Copy link
Contributor

Currently, an option called --icommands-only can be passed to the build script used by the builder container to only build iCommands in the core builder. I think we should just make these entirely separate builders.

The risk here is developers using the development environment will need to remember to re-build iCommands whenever irods-runtime changes to ensure that the right changes are being used in testing.

@alanking alanking added the enhancement New feature or request label Feb 23, 2024
@korydraughn
Copy link
Contributor

What's the motivation for separating them?

@alanking
Copy link
Contributor Author

Simplifying things, mostly. Also gives us the option to move away from iCommands more easily in the future. Could also serve as an example "client builder", not that this would be highly valuable given the low number of C/C++ clients being developed. :)

@korydraughn
Copy link
Contributor

I see. Got it, thanks.

@trel
Copy link
Member

trel commented Feb 23, 2024

tiny boxes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants