Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: improve mocking in tests #600

Open
mxsasha opened this issue Dec 19, 2021 · 0 comments
Open

Refactor: improve mocking in tests #600

mxsasha opened this issue Dec 19, 2021 · 0 comments
Assignees
Labels
refactoring Internal refactoring tasks

Comments

@mxsasha
Copy link
Collaborator

mxsasha commented Dec 19, 2021

IRRD's tests use a lot of mocking, but it's all a bit messy, especially when mocking database results. We may be able to extract a common mock configurator that will improve clarity of tests. Especially for the commonly mocked parts, like database and RPKI validator. Some places also still use the legacy method of overriding settings with env variables, rather than the new config_override() fixture.

@mxsasha mxsasha added the refactoring Internal refactoring tasks label Dec 19, 2021
@mxsasha mxsasha self-assigned this Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal refactoring tasks
Projects
None yet
Development

No branches or pull requests

1 participant