Optimize and secure Docker image #858
Labels
improvement
Not a new feature, but makes Isso more pleasant to use
needs-contributor
Someone needs to implement this. Help wanted!
testing/ci
Test coverage & GitHub actions etc.
Milestone
The
Dockerfile
might be using non-optimal base images and have too many steps as of now.I'm no docker expert and pretty much just threw together what I saw in other projects in order to make the image work with newer npm packages in #841.
For instance, we might drop the root user, use some kind of tighter sandboxing, use signed images, only expose to localhost instead of 0.0.0.9, ...
I found following potentially relevant material:
Maybe wonderfall has a few ideas, seeing souramoo/commentoplusplus#89 and that they maintain(ed) https://github.com/wonderfall/docker-isso
Also: Allow configuration through environment variables passed to docker image. Related: #397
Putting on backburner for now.
Another idea: Passing environment variables to the image, to be used instead of a config file. Requires general support for parsing env variables, see #397
The text was updated successfully, but these errors were encountered: