Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: invalid filenames #33

Open
ajr44 opened this issue Jul 9, 2019 · 0 comments
Open

Windows: invalid filenames #33

ajr44 opened this issue Jul 9, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@ajr44
Copy link

ajr44 commented Jul 9, 2019

In OutputFiles.rewritePath() the filename is taken from the URL, but some URL filenames have characters that are illegal (at least on Windows).

ie if I am testing my site at www.example.org/test.html?testnumber=1, this will attempt to save a file as test.html?testnumber=1puppeteerTemp-inline.js but the ? is invalid in windows filenames.
@bcoe bcoe added the bug Something isn't working label Jul 23, 2019
@ajr44 ajr44 mentioned this issue Aug 1, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcoe @ajr44