Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/actions/action-npm-release should only create npm package not run npm build & still using repo it-at-m/.github #109

Open
ejcsid opened this issue Jan 23, 2025 · 2 comments · May be fixed by it-at-m/refarch-templates#853 or it-at-m/lhm_actions#24
Assignees
Labels
bug Something isn't working

Comments

@ejcsid
Copy link
Contributor

ejcsid commented Jan 23, 2025

https://github.com/it-at-m/.github/blob/main/.github/actions/action-npm-release/action.yml shouldn't have dependencies within a repo.

Steps:

  • checkout code
  • build

must be removed.

Also, action-release-npm is still using action in repository it-at-m/.github.:

https://github.com/it-at-m/lhm_actions/blob/e4cb32f326456cfbd58b810d978398174d832c72/action-templates/actions/action-npm-release/action.yml#L62

This must be changed.

@ejcsid ejcsid added this to SPS Jan 23, 2025
@ejcsid ejcsid converted this from a draft issue Jan 23, 2025
@ejcsid ejcsid added the bug Something isn't working label Feb 13, 2025
@ejcsid ejcsid changed the title .github/actions/action-npm-release should only create npm package not run npm build .github/actions/action-npm-release should only create npm package not run npm build & still using repo it-at-m/.github Feb 13, 2025
@ejcsid ejcsid marked this as a duplicate of it-at-m/lhm_actions#11 Feb 13, 2025
@hupling
Copy link
Collaborator

hupling commented Mar 5, 2025

also dann kopieren wir es einfach rüber ist halt dann so. mit dem dupplikate code

@hupling
Copy link
Collaborator

hupling commented Mar 5, 2025

@devtobi theoretisch könnt ihr auch in der package.json das hinzufügen

{
  "scripts": {
    "preversion": "npm test",
    "version": "npm run build && git add -A dist",
    "postversion": "git push && git push --tags && rm -rf build/temp"
  }
}

@hupling hupling linked a pull request Mar 5, 2025 that will close this issue
@hupling hupling self-assigned this Mar 5, 2025
@hupling hupling linked a pull request Mar 5, 2025 that will close this issue
@hupling hupling linked a pull request Mar 5, 2025 that will close this issue
@hupling hupling linked a pull request Mar 5, 2025 that will close this issue
@hupling hupling moved this from Todo to Test / Review in SPS Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Test / Review
Development

Successfully merging a pull request may close this issue.

2 participants