-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using request-html for Cross Device flow within the integration test #265
Comments
Expanding the issue for the readers of the future, which might need some amount of context to understand where this issue emerged. The current design of the cross device integration test has very limited capabilities regarding the behaviour of the javascript running in the QRcode page.
At the moment of writing this post, step (1) is done by parsing the html page scouting for the js variable which holds the status endpoint (which is plain dirty); step (2) is not done at all. |
playwrite seems to be better |
It appears that this approach is promising. Will follow with a pull request when the test is compplete. Note that some isssues already emerged. For example if I'm not mistaken this does not work eudi-wallet-it-python/example/satosa/templates/qr_code.html Lines 141 to 146 in da47074
as href is not a valid attribute for tag <button> , see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button
|
we may use this library to test js execution
https://pypi.org/project/requests-html/
The text was updated successfully, but these errors were encountered: