Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Satosa] [Bug] Errore verifica corretteza in integration test #269

Closed
Zicchio opened this issue Sep 17, 2024 · 1 comment · Fixed by #273
Closed

[Satosa] [Bug] Errore verifica corretteza in integration test #269

Zicchio opened this issue Sep 17, 2024 · 1 comment · Fixed by #273
Assignees
Labels
bug Something isn't working

Comments

@Zicchio
Copy link
Collaborator

Zicchio commented Sep 17, 2024

L'esito finale dell'integration test controlla gli attributi ottenuti confrontandoli con quelli attesi in questa riga di codice

for attribute in attributes:
name = attribute["name"]
value = attribute.contents[0].contents[0]
expected_value = expected.get(name, None)
if expected_value:
assert value == expected_value.lower()

questo check non è formalmente corretto. Ad esempio, se l'autenticazione non genera nessun attributo dell'utente, o li genera con nome sbagliato, il test viene comunque superato.

@Zicchio Zicchio added the bug Something isn't working label Sep 17, 2024
@Zicchio Zicchio self-assigned this Sep 17, 2024
@peppelinux
Copy link
Member

Resolved by #273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants