Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible requirement between setup.py and CI pipeline #275

Open
Zicchio opened this issue Sep 19, 2024 · 2 comments
Open

Incompatible requirement between setup.py and CI pipeline #275

Zicchio opened this issue Sep 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working CI CI
Milestone

Comments

@Zicchio
Copy link
Collaborator

Zicchio commented Sep 19, 2024

The dependency on https://github.com/openwallet-foundation-labs/sd-jwt-python is defined as:

  1. on the setup.py file, latest RELEASE is used (which currently is v0.10.4, commit 9181a0a4514b7de2cc30a84d320b509e9fc5cb59)
  2. on the CI pipeline, the latest COMMIT is used
    python -m pip install git+https://github.com/openwallet-foundation-labs/sd-jwt-python.git

unfortunatly the two are currently not compatible for our puposes and the code currently assume that latest COMMIT (case 2) is used, see PR #250; in other word the current code is not compatible with latest release of sd-jwt

IMO we should either:

  • (preferred) stick with one choice in both cases, likely (?) by using the lateast RELEASE also in CI pipeline (this require a small code change to rollback PR 250) or
  • rewrite the code to tolerate either version

NOTE: this also has side effects on the project satosa-it, where case (1) is assumed
https://github.com/italia/Satosa-Saml2Spid/blob/22c25951cfeb601f1582963d2c4440876e95bda9/requirements.txt#L24

@Zicchio Zicchio added bug Something isn't working CI CI labels Sep 19, 2024
@peppelinux
Copy link
Member

I suggest to use the last dev version

I'm reaching Daniel Fett to release the next version 0.11 of sd-jwt, therefore alinged with the current dev branch

@peppelinux
Copy link
Member

The solution will be achieved by this: #281

@peppelinux peppelinux assigned PascalDR and unassigned peppelinux Oct 23, 2024
@peppelinux peppelinux added this to the 0.9.1 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI CI
Projects
Status: In Progress
Development

No branches or pull requests

3 participants