Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer adding Session Key on-chain until first on-chain action. #33

Open
gakonst opened this issue Jan 24, 2025 · 1 comment
Open

Defer adding Session Key on-chain until first on-chain action. #33

gakonst opened this issue Jan 24, 2025 · 1 comment

Comments

@gakonst
Copy link

gakonst commented Jan 24, 2025

Currently, we genreate a scoped session key & immediately add it to the keychain. It might be worth adding a utility which generates the session key & signs over it, but defers putting the message on-chain / combines it with the first on-chain action.

So e.g the E2E flow would be:

  1. Passkey popup -- signs adding a new session key
  2. Sign action w/o popup w/ session key
  3. Submit (1) & (2) in bundle, (1) will add the session key in the contract, and (2) will succeed because that key will be valid then.
@gakonst
Copy link
Author

gakonst commented Jan 29, 2025

This also applies for the user's PassKey initialization during onboarding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant