Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side navigation is not functioning as expected in the v14 release branch #673

Closed
brentswisher opened this issue Jan 22, 2024 · 2 comments
Closed

Comments

@brentswisher
Copy link
Contributor

Expected behavior
The sidenav component is visible when it is expected to be.

Actual behavior
When viewing storybook on the v14 branch, the sidenav component is not displaying when it should be. It was also flagged by chromatic in a couple of builds: https://60919c26122bd50039b34644-xcjezwbxfi.chromatic.com/?path=/story/components-layout--one-column-with-sidenav&globals=viewport.width:1056

Steps to reproduce the issue

  1. Run storybook on the v14 branch
  2. Look at the stories which contain a sidenav component:
    1. Layouts > "with sidenav" stories
    2. Pages > Reports
  3. See that the sidenav is not displaying like it used to

Screenshots or code
Screenshot 2024-01-22 at 8 53 51 AM

Pharos version
v14 release branch

Your environment

  • OS: macOS
  • Browser: Chrome
  • Version: 120.0.6099.216

Additional information
This seems to have happened around the time of #478. The components are mounted but are not being set to be visible.

@daneah
Copy link
Member

daneah commented Jan 22, 2024

Does this seem different than #653?

@brentswisher
Copy link
Contributor Author

I think so, as that is focused on the Pharos site and this is related to the storybook stories? @satya-achanta-venkata also took a look at that during our working session and thought it was already working as expected from what he could see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants